chore: Fixed incorrect pinning of @elastic/transport #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizob2828
requested changes
Apr 3, 2024
bizob2828
reviewed
Apr 3, 2024
test/versioned/elastic/package.json
Outdated
| @@ -11,18 +11,20 @@ | |||
| "node": ">=16" | |||
| }, | |||
| "dependencies": { | |||
| "@elastic/elasticsearch": "7.13.0" | |||
| "@elastic/elasticsearch": "7.13.0", | |||
| "@elastic/transport": "8.4.1" | |||
There was a problem hiding this comment.
this isn't needed. this is only testing on 7.13.0 which doesn't have @elastic/transport
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2120 +/- ##
=======================================
Coverage 97.20% 97.20%
=======================================
Files 251 251
Lines 42317 42317
=======================================
Hits 41133 41133
Misses 1184 1184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bizob2828
approved these changes
Apr 3, 2024
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR didn't quite do it.