chore: Updated versioned tests to support upcoming tooling #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
commented
Apr 15, 2024
bizob2828
previously approved these changes
Apr 15, 2024
test/versioned/cls/package.json
Outdated
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "name": "cls-tests", | |||
| "targets": ["continuation-local-storage"], | |||
There was a problem hiding this comment.
we don't instrument cls, i think this is just a test to make sure we don't affect it. you can prob omit this one
bizob2828
approved these changes
Apr 16, 2024
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to support #2102.