fix: Fixed instrumentation of Fastify via ESM #2158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added replication test.
bizob2828
requested changes
Apr 24, 2024
It did reproduce it. But now it's not and I'm very confused. |
bizob2828
requested changes
Apr 24, 2024
There was a problem hiding this comment.
Ok we talked IRL. I don't think this is the best place for this fix. I traced this back to #1894 as the regression. I think the fix should be here. That way we won't have code scattered that checks the nrEsmProxy symbol. Keep in mind and it'll be obvious because we test pg in esm but there's code in pg instrumentation that checks this symbol as well
|
This'll be my priority on 2024-04-25. Too late in the day to get into complicated work like this. |
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #2155.