add .npmignore to ignore examples and test folder #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sinewyk thanks for the suggestions, agreed that we should at the very least exclude tests and examples. We might go with .npmignore instead for now - smaller change, and to avoid accidental breakage due to missing files. |
Sinewyk
changed the title
|
PR updated to ignore instead. |
|
This was merged out of band into v1.27.0. Thanks for the contribution! |
|
Nah, thank you =). |
bizob2828
added a commit
to bizob2828/node-newrelic
that referenced
this pull request
Apr 19, 2024
…/axios-and-newrelic-1.6.0 chore(deps): bump axios and newrelic
bizob2828
added a commit
to bizob2828/node-newrelic
that referenced
this pull request
Apr 23, 2024
…/axios-and-newrelic-1.6.0 chore(deps): bump axios and newrelic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
examples and tests are not useful in a npm package
ref https://docs.npmjs.com/files/package.json
To simplify the files array and make it more resilient to change, we could also move all source files into lib and use the main field of the package.json
Also, NEWS.md should probably be renamed CHANGELOG.md to even more strip down the files config.