chore: Added otel compliant attributes for database spans #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrickard
force-pushed
the
NR-260092/add-otel-db-props
branch
from
e67b5f5
to
b4b7a08
Compare
bizob2828
requested changes
Apr 30, 2024
lib/spans/streaming-span-event.js
Outdated
| @@ -64,7 +64,7 @@ class StreamingSpanEvent { | |||
| * | |||
| * @param {string} key Name of the attribute to be stored. | |||
| * @param {string|boolean|number} value Value of the attribute to be stored. | |||
| * @param {boolean} [truncateExempt=false] Set to true if attribute should not be truncated. | |||
| * @param {boolean} [truncateExempt] Set to true if attribute should not be truncated. | |||
There was a problem hiding this comment.
this appears to default to false, why was the jsdoc updated?
There was a problem hiding this comment.
What's weird is that I didn't update that. That may be fallout from running lint or something.
There was a problem hiding this comment.
Or it's our pre-commit hooks.
bizob2828
previously approved these changes
Apr 30, 2024
Signed-off-by: mrickard <maurice@mauricerickard.com>
…faults that had been stripped from JSDoc declarations Signed-off-by: mrickard <maurice@mauricerickard.com>
…rties Signed-off-by: mrickard <maurice@mauricerickard.com>
mrickard
force-pushed
the
NR-260092/add-otel-db-props
branch
from
7f0e322
to
707ab6e
Compare
bizob2828
approved these changes
May 1, 2024
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
May 1, 2024
bizob2828
pushed a commit
that referenced
this pull request
May 20, 2024
Signed-off-by: mrickard <maurice@mauricerickard.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added OTEL-compliant
db.system,server.address, andserver.portproperties to db spans.How to Test
This PR includes additions to
test/unit/spans/span-event.test.jsandtest/unit/spans/streaming-span-event.test.js, so running unit tests will include these.Related Issues
Closes #2149
Closes NR-260092