chore: Fixed superagent versioned tests #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
force-pushed
the
fix-superagent-tests
branch
from
449378b
to
7da6549
Compare
jsumners-nr
force-pushed
the
fix-superagent-tests
branch
from
7da6549
to
c575438
Compare
mrickard
approved these changes
May 10, 2024
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
May 10, 2024
bizob2828
pushed a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The superagent tests were making requests to the live
https://newrelic.comserver. Sometime between 2024-05-09 and 2024-05-10, that server started returning a 301 for requests in order to append a device parameter, e.g.?device=desktop.This PR resolves that issue by making these tests query a local server.