Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at the code and found it odd that the
Config.initialize()
does take a config parameter but it's not used in./index.js
.Therefor I'd like propose this change. I do realise that this is a breaking change for the package. Now instead of doing
require('newrelic)
, it would need to berequire('newrelic')()
.This additionally allows for use of sending a config into the constructor of the package instead of having to rely on a file in the root of the project so projects could do something like
require('newrelic')(config)
which could then be located else where than in the root. I generally don't like having files located in the root due to the folder structure in projects I work on. I don't like having hard dependencies on where files are located as configurations to packagesIf there's a specific reason for the other API feel free to close this. Since the config initialiser accepts the argument already this makes I think this could make sense.