-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of hasOwnProperty
in node v8
#250
Conversation
similar problem to aseemk/requireDir#46, because of using clean objects in mscdex/io.js@3d8528d
Thanks for the PR. We are aware of this, and planning to release a more comprehensive support for Node 8 soon. |
@martinkuba do you have a release date for this fix? |
I can't give you an exact date, but Node 8 support is a high priority for us, and we are actively working on it. Please hang tight, update coming soon. |
Can you guys at least release a hotfix before more comprehensive support for node 8? |
Seconded - we just saw all our reporting drop off a cliff... would be very nice to have it back. |
We are aiming to release tomorrow morning (PDT). This will include a fix for this issue and a couple other items that would have resulted in data loss in Node 8. |
We just released agent version 1.40.0 which should resolve this and other Node 8 related issues. Please give it a whirl and let us know if it works for you! |
- [x] Refer to: newrelic/node-newrelic#250
similar problem to aseemk/requireDir#46
this is because of using clean objects in mscdex/io.js@3d8528d
don't know if this conforms to code style https://github.com/vnguyen94/node-newrelic/blob/19519d6270a5007d5e12d229618ffc7c4b880f4b/lib/uninstrumented.js#L73-L76, feel free to review that