Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of hasOwnProperty in node v8 #250

Closed
wants to merge 1 commit into from
Closed

Use of hasOwnProperty in node v8 #250

wants to merge 1 commit into from

Conversation

vankhoawin
Copy link

similar problem to aseemk/requireDir#46
this is because of using clean objects in mscdex/io.js@3d8528d

don't know if this conforms to code style https://github.com/vnguyen94/node-newrelic/blob/19519d6270a5007d5e12d229618ffc7c4b880f4b/lib/uninstrumented.js#L73-L76, feel free to review that

similar problem to aseemk/requireDir#46, because of using clean objects in mscdex/io.js@3d8528d
@martinkuba
Copy link
Contributor

Thanks for the PR. We are aware of this, and planning to release a more comprehensive support for Node 8 soon.

@khalidsalomao
Copy link

@martinkuba do you have a release date for this fix?

@martinkuba
Copy link
Contributor

I can't give you an exact date, but Node 8 support is a high priority for us, and we are actively working on it. Please hang tight, update coming soon.

@mugli
Copy link

mugli commented Jun 4, 2017

Can you guys at least release a hotfix before more comprehensive support for node 8?

@abritinthebay
Copy link

Seconded - we just saw all our reporting drop off a cliff... would be very nice to have it back.

@NatalieWolfe
Copy link
Contributor

We are aiming to release tomorrow morning (PDT). This will include a fix for this issue and a couple other items that would have resulted in data loss in Node 8.

@NatalieWolfe
Copy link
Contributor

We just released agent version 1.40.0 which should resolve this and other Node 8 related issues. Please give it a whirl and let us know if it works for you!

@vankhoawin vankhoawin closed this Jun 7, 2017
@alxndr
Copy link

alxndr commented Jun 7, 2017

Allright, we're back!
screen shot 2017-06-07 at 14 25 19

geshan pushed a commit to geshan/node-newrelic-plus that referenced this pull request Jun 8, 2017
bizob2828 added a commit to bizob2828/node-newrelic that referenced this pull request Apr 19, 2024
bizob2828 added a commit to bizob2828/node-newrelic that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants