Should check if isActive is a function first #270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psvet
suggested changes
Feb 26, 2019
There was a problem hiding this comment.
Hey @pegurnee, thanks for the PR! This is a fair check, but it's concerning that isActive would be missing at all, so this is more of a band-aid. If you're able to isolate the issue in an integration test, that would be ideal before moving forward. Otherwise, I'd actually suggest reaching out to support@newrelic.com so our team can properly investigate the cause with more details about your environment.
|
Hey, @pegurnee! Is this still an issue? If you ran into any issues while trying to write a test for your case, let us know and we can help you out. |
|
@lykkin Actually, we were having other problems. I'm going to dismiss this one and call it a day! Sorry for the absolutely delayed response. |
bizob2828
pushed a commit
to bizob2828/node-newrelic
that referenced
this pull request
Apr 19, 2024
bizob2828
pushed a commit
to bizob2828/node-newrelic
that referenced
this pull request
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE LOG
INTERNAL LINKS
NOTES
If isActive is not a function at this point we have an issue.