Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Memcached undefined error #272

Merged
merged 2 commits into from
Mar 4, 2019

Conversation

bwolfe
Copy link
Contributor

@bwolfe bwolfe commented Feb 22, 2019

I am getting these errors:

TypeError: Cannot read property 'split' of undefined\n at Client.commandWrapper (/usr/app/node_modules/newrelic/lib/instrumentation/memcached.js:51:51)

on this line of code: mycache.del(key)

The del() call was after a key (probably) timed out or potentially removed by another pod. I cannot replicate this in dev/staging though! >:O

I attempted to write integration tests, but could not get it to fail in this process:

  1. Deleting a key after a delete
  2. Deleting a key after previous key timed out
  3. Deleting a key after end() entire cache.

@NatalieWolfe
Copy link
Contributor

Thanks for this fix, Ben! I'll merge it into our internal repo to make sure it gets released ASAP.

@psvet psvet merged commit e4f30df into newrelic:master Mar 4, 2019
@bwolfe bwolfe deleted the memcached-undefined-error branch May 2, 2019 17:29
bizob2828 pushed a commit to bizob2828/node-newrelic that referenced this pull request Apr 19, 2024
bizob2828 pushed a commit to bizob2828/node-newrelic that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants