Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump grpc-js version to v1.2.5 #606

Merged
merged 1 commit into from
Feb 1, 2021
Merged

bump grpc-js version to v1.2.5 #606

merged 1 commit into from
Feb 1, 2021

Conversation

carlo-808
Copy link
Contributor

Proposed Release Notes

  • Upgrade @grpc/grpc-js to v1.2.5 to fix non-propagation of internal http2 errors

Links

Closes: #605

Details

gprc-js fix PR: grpc/grpc-node#1658

@carlo-808 carlo-808 added risk: low This change does not impact critical areas of the code and is expected to have minimal risk. semver: patch Backwards compatible fixes. ready for review labels Jan 29, 2021
michaelgoin
michaelgoin approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@michaelgoin michaelgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michaelgoin michaelgoin merged commit 282a18d into newrelic:main Feb 1, 2021
@carlo-808 carlo-808 mentioned this pull request Feb 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelgoin michaelgoin michaelgoin approved these changes

Assignees
No one assigned
Labels
ready for review risk: low This change does not impact critical areas of the code and is expected to have minimal risk. semver: patch Backwards compatible fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grpc stream drain event not firing after initial drain event
2 participants
@carlo-808 @michaelgoin