Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added instrumentation tracking to support newrelic issue 2033 #195

Merged
merged 1 commit into from Apr 2, 2024

Conversation

jsumners-nr
Copy link
Contributor

This PR updates the minimum version of newrelic in order to utilize the instrumentation tracker instead of Object.create(null) in the agent helper.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.27%. Comparing base (4254669) to head (849bc2e).

Files Patch % Lines
lib/agent.js 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   80.25%   80.27%   +0.01%     
==========================================
  Files          23       23              
  Lines        3378     3386       +8     
==========================================
+ Hits         2711     2718       +7     
- Misses        667      668       +1     
Flag Coverage Δ
unit-tests-16.x 80.27% <88.88%> (+0.01%) ⬆️
unit-tests-18.x 80.27% <88.88%> (+0.01%) ⬆️
unit-tests-20.x 80.27% <88.88%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsumners-nr jsumners-nr merged commit 730e747 into newrelic:main Apr 2, 2024
9 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Apr 2, 2024
@jsumners-nr jsumners-nr deleted the oh-sweet-shimmmer-2 branch April 2, 2024 11:40
@github-actions github-actions bot mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants