Improvements and Kubernetes v1.22 support #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
After making linter configuration effective, linter popped up new issues. This commit addresses them in a minimal way. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
As usually it is hidden. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
As part of #45 Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
roobre
reviewed
Aug 19, 2021
|
LGTM, let's wait for the release of nri-kubernetes. |
roobre
approved these changes
Aug 19, 2021
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Previous link now redirects to new link and old link will be not available by the end of this year. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
As part of #45. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Closes #45 Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Closes #38 Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
To fix snyk security scan. Upstream update is pending here: spf13/afero#312 Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
invidian
force-pushed
the
invidian/improvements
branch
from
f9bb37b
to
33236e1
Compare
gsanchezgavier
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft as in theory we should wait for
nri-kubernetesrelease.We should also consider dropping support for Kubernetes v1.15, though there is no requirement to do so here as far as I know.
Closes #38
Closes #45