Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cgroup path when cgroup driver is systemd #29

Merged
merged 27 commits into from
May 8, 2020

Conversation

cristianciutea
Copy link
Contributor

This PR will make the nri-docker integration compatible with systemd cgroup driver

@cristianciutea cristianciutea requested a review from a team May 5, 2020 10:30
@CLAassistant
Copy link

CLAassistant commented May 5, 2020

CLA assistant check
All committers have signed the CLA.

src/docker.go Outdated
integrationVersion = "0.6.0"
dockerClientVersion = "1.24" // todo: make configurable
integrationName = "com.newrelic.docker"
integrationVersion = "0.7.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the next version released (v1.3.0).

Copy link

@carlosroman carlosroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cristianciutea cristianciutea merged commit e4b57e8 into master May 8, 2020
@cristianciutea cristianciutea deleted the gmerkushev/cgroup-detection branch May 8, 2020 07:54
@jayv
Copy link

jayv commented May 12, 2020

@cristianciutea @carlosroman any rough estimate when this could land in newrelic infra agent?

We're running into this issue on a platform that is setup with systemD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants