Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tls_config add cert & key parameters #295

Merged
merged 2 commits into from
May 14, 2021
Merged

Conversation

Kav91
Copy link
Member

@Kav91 Kav91 commented Mar 24, 2021

Some endpoints require tls cert/key x509 keypair else insecureSkipVerify needs to be used.
PR extends the existing tls_config to accept the two parameters and updates the doc reference.

Required for this issue

cc/ @bpschmitt @noly @josemore

@cristianciutea cristianciutea self-requested a review May 14, 2021 10:35
@cristianciutea
Copy link
Contributor

LGTM

@cristianciutea cristianciutea merged commit 936dbb4 into master May 14, 2021
@cristianciutea cristianciutea deleted the kav/certKeySupport branch May 14, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants