Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test): added test to show expected behaviour #289

Merged
merged 3 commits into from
Apr 2, 2024
Merged

feat(test): added test to show expected behaviour #289

merged 3 commits into from
Apr 2, 2024

Conversation

paologallinaharbur
Copy link
Member

This test shows that if there are not active consumers "ka-consumer" is not generated and we get merely "ka-consumer-group" and "ka-consumer-group-topic"

@paologallinaharbur paologallinaharbur requested a review from a team as a code owner March 27, 2024 10:29
sigilioso
sigilioso approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@sigilioso sigilioso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including this.

I've left a couple of comments in case we could help understanding the use-case with additional comments, but feel free to ignore them! 🙂

src/consumeroffset/kafka_offset_collect_test.go Show resolved Hide resolved
src/consumeroffset/kafka_offset_collect_test.go Show resolved Hide resolved
@paologallinaharbur paologallinaharbur merged commit decc406 into master Apr 2, 2024
11 checks passed
@paologallinaharbur paologallinaharbur deleted the feat/test branch April 2, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigilioso sigilioso sigilioso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paologallinaharbur @sigilioso