Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SASL/PLAIN and SASL/SCRAM mechanisms #82

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

dylanmei
Copy link
Contributor

Description of the changes

Add support for additional SASL mechanisms for authenticating with Kafka brokers.

Link the issue it solves: #58

PR Review Checklist

Author

  • the PR should focus on a single subject. Change only relevant files to the problem you’re working on
    Clean and format the code
  • add unit tests for your changes and make sure all unit tests are passing
  • add a risk label after carefully considering the "blast radius" of your changes
  • describe the intent of your changes in the description. don't just rewrite your code in prose
  • assign at least one reviewer
  • address the feedback

Reviewer

  • review code for readability
  • verify that high risk behavior changes are well tested
  • check license for any new external dependency
  • ask questions about anything that isn't clear and obvious
  • approve the PR when you consider it's good to merge

@CLAassistant
Copy link

CLAassistant commented Apr 11, 2020

CLA assistant check
All committers have signed the CLA.

@camdencheek
Copy link
Contributor

Hi @dylanmei -- thanks for the PR! That was a quick turnaround. At a brief scan, this looks great. I'll do my best to provide a proper review ASAP, and get this merged in.

@camdencheek camdencheek self-requested a review April 11, 2020 16:53
@camdencheek camdencheek self-assigned this Apr 11, 2020
@camdencheek
Copy link
Contributor

Hi @dylanmei -- so sorry for the slow turnaround on this. It's been a whirlwind of a week. I looked over the PR and it just needed a tiny bit of touchup (mostly linter complaints), but I included my local changes in the merge. These changes will be released as part of v2.13.0, which I'm kicking off a release for right now

@camdencheek camdencheek merged commit efa1523 into newrelic:master Apr 21, 2020
@tmancill
Copy link

@camdencheek Any update on this?

@camdencheek
Copy link
Contributor

@tmancill this was released yesterday. It's available as part of v2.13.0. I'll try to get documentation updated on it soon

@Neustradamus
Copy link

@dylanmei: Thanks a lot for all about SCRAM.

Linked to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants