Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update modules #111

Merged
merged 5 commits into from May 28, 2021
Merged

Update modules #111

merged 5 commits into from May 28, 2021

Conversation

paologallinaharbur
Copy link
Member

@paologallinaharbur paologallinaharbur commented May 27, 2021 •
edited

  • Update dependencies
  • Update to /v2

[done] To be rebase and merged after #110

Take over #107

@paologallinaharbur paologallinaharbur force-pushed the pgallina/updateModules branch 3 times, most recently from 61269be to ec02afc Compare May 27, 2021 15:11
roobre
roobre approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@roobre roobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, just a the minor comment on the nvidia resource

src/kubelet/metric/resource_test.go Outdated Show resolved Hide resolved
roobre
roobre reviewed May 28, 2021
View reviewed changes
assets/licence/rules.json Outdated Show resolved Hide resolved
src/kubelet/metric/resource_test.go Outdated Show resolved Hide resolved
@paologallinaharbur paologallinaharbur merged commit f187644 into main May 28, 2021
@paologallinaharbur paologallinaharbur deleted the pgallina/updateModules branch May 28, 2021 12:04
@invidian invidian mentioned this pull request May 31, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roobre roobre roobre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paologallinaharbur @roobre