Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General improvements #171

Merged
merged 6 commits into from Jul 23, 2021
Merged

General improvements #171

merged 6 commits into from Jul 23, 2021

Conversation

invidian
Copy link
Contributor

Code touched as part of #165

Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
* Group flag variables together
* Consistently use only single logger
* Improve error messages

Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
If there is more than one node on the cluster, test result may end with
false negatives.

Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
@invidian invidian requested a review from roobre July 23, 2021 14:51
Copy link
Contributor

@roobre roobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@invidian invidian merged commit 8fc4b61 into main Jul 23, 2021
@invidian invidian deleted the invidian/improvements branch July 23, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants