Create the config and namespace filterer #457
Conversation
marcsanmi
force-pushed
the
msanmiquel/add-config-namespace-filterer
branch
2 times, most recently
from
5dbcaa2
to
ac1c7bb
Compare
marcsanmi
force-pushed
the
msanmiquel/add-config-namespace-filterer
branch
from
ac1c7bb
to
2f03281
Compare
marcsanmi
changed the title
| // NamespaceFilterer provides an interface to filter namespaces. | ||
| type NamespaceFilterer interface { | ||
| IsAllowed(namespace string) bool | ||
| } |
There was a problem hiding this comment.
I wonder if this interface is too specific. What would be the advantage of having a filter specific to namespaces, as opposed to a filter that takes in fetch.RawMetrics and returns a bool? NamespaceFilter could be a particular implementation of this, looking for metrics["namespace"]
There was a problem hiding this comment.
You're right, I updated the interface definition and implementation here e57ba69.
There was a problem hiding this comment.
After talking with @alvarocabanas and @sigilioso, we decided to move back again to the initial definition. Implementing the solution suggested above would imply some refactor in order to avoid cyclic dependencies between definition and discovery packages and to make the code maintainable.
Done in 95f8b9d.
We can talk about this when you come back 🙂
Closes https://github.com/newrelic/newrelic-coreint/issues/324.
Filtering namespaces basically works this way:
namespaceSelector.matchLabels.namespaceSelector.matchExpressions(You can check as well https://pkg.go.dev/k8s.io/apimachinery/pkg/labels#Parse)For more in depth details about the final solution, take a look at this internal doc.