Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move filter creation to KSM & Kubelet methods #487

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

alvarocabanas
Copy link
Contributor

Signed-off-by: Alvaro Cabanas acabanas@newrelic.com

Signed-off-by: Alvaro Cabanas <acabanas@newrelic.com>
@alvarocabanas alvarocabanas requested review from sigilioso, marcsanmi and a team June 13, 2022 09:00
Copy link
Contributor

@sigilioso sigilioso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for taking care of it and sorry for the previous suggestion

Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alvarocabanas alvarocabanas merged commit 8715620 into main Jun 13, 2022
@alvarocabanas alvarocabanas deleted the move_filter_creation_setup_methods branch June 13, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants