Adding new attribute ReplicaFailure to deployment workload
#725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanjjaramillo
force-pushed
the
juanjjaramillo/new_deployment_attribute
branch
from
9d0d820
to
2e1967a
Compare
…te in a true-or-NULL basis
juanjjaramillo
force-pushed
the
juanjjaramillo/new_deployment_attribute
branch
from
8f09d67
to
80ec84a
Compare
philkuz
approved these changes
Apr 25, 2023
nserrino
reviewed
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Kubernetes team is updating metrics for all supported workloads and services. Specifically, kube-state-metrics has upgraded several metrics and services from
experimentaltostable.We noted in the Kubernetes repository that there are only three valid conditions of a deployment:
AvailableProgressingReplicaFailureWhile they are briefly mentioned in the documentation, there is no statement indicating they are the only valid conditions.
PR Changes
This PR makes changes to the agent to start scraping the attribute
ReplicaFailurefrom KSM's metrickube_deployment_status_conditionto make sure we scrape all valid conditions for Deployment workloads.Related PRs
nri-kubernetes #725
infra-integration-specs #313
infra-metrics-utils #85
dirac #8087
dirac_async_query_service #3347
window-aggregation-merger #811
partial-aggregation-windower #529
Testing Plan
K8s*Sampletables