Add CronJob dashboard tests. #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanjjaramillo
force-pushed
the
add-cronjob-tests
branch
from
7a251a0
to
fd83dde
Compare
juanjjaramillo
force-pushed
the
add-cronjob-tests
branch
from
5eb0950
to
cda7467
Compare
juanjjaramillo
approved these changes
Nov 9, 2023
juanjjaramillo
force-pushed
the
add-cronjob-tests
branch
from
cda7467
to
cde8c45
Compare
svetlanabrennan
approved these changes
Nov 10, 2023
|
LGTM. I've also ran these nrql tests locally and they pass for me as well. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add e2e nrql tests for cronjob dashboard.