Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated KSM unit tests #876

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Updated KSM unit tests #876

merged 4 commits into from
Sep 12, 2023

Conversation

svetlanabrennan
Copy link
Contributor

@svetlanabrennan svetlanabrennan commented Sep 12, 2023 •
edited
Loading

Which problem is this PR solving?

Updated KSM tests after updating KSM dependency

Short description of the changes

  • Removed Optional: true from metric definition file so we can just use exclude.Metrics(<metricName>) in the test files instead.
  • Replaced namespace and deploymentName attribute on KSM "deployment" to be retrieved from kube_deployment_created instead of kube_deployment_labels since kube_deployment_labels is not enabled by default.
  • Removed some unnecessarily excluded metrics from unit tests

Type of change

Please delete options that are not relevant.

  • New feature / enhancement (non-breaking change which adds functionality)

New Tests?

Please describe the new tests that were added (if applicable).

  • This change requires changes in testing:
    • unit tests
    • e2e tests

Checklist:

  • Add changelog entry following the contributing guide
  • Tests have been added
  • Documentation has been updated

@svetlanabrennan svetlanabrennan changed the title Updated ksm unit tests Updated KSM unit tests Sep 12, 2023
@svetlanabrennan svetlanabrennan marked this pull request as ready for review September 12, 2023 17:04
@svetlanabrennan svetlanabrennan requested a review from a team as a code owner September 12, 2023 17:04
juanjjaramillo
juanjjaramillo approved these changes Sep 12, 2023
View reviewed changes
src/ksm/ksm_test.go Outdated Show resolved Hide resolved
@svetlanabrennan svetlanabrennan merged commit b0af02d into main Sep 12, 2023
23 checks passed
@svetlanabrennan svetlanabrennan deleted the update-metrics-exceptions branch September 12, 2023 18:38
csongnr pushed a commit that referenced this pull request Nov 9, 2023
@svetlanabrennan @csongnr
Updated KSM unit tests (#876)
f655304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanjjaramillo juanjjaramillo juanjjaramillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svetlanabrennan @juanjjaramillo