Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add k8s v1.28.0-rc.1 support #919

Merged
merged 16 commits into from
Nov 2, 2023
Merged

chore: Add k8s v1.28.0-rc.1 support #919

merged 16 commits into from
Nov 2, 2023

Conversation

svetlanabrennan
Copy link
Contributor

@svetlanabrennan svetlanabrennan commented Oct 24, 2023 •
edited
Loading

Description

Prepare for 1.28 support.

Changes made:

  • Removed 1.23 support
  • Added v1.28.0-rc.1 support
  • Confirmed unit tests pass with v1.28.0-rc.1
  • Confirmed e2e tests pass with v1.28.0-rc.1

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Add changelog entry following the contributing guide
  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@svetlanabrennan svetlanabrennan marked this pull request as ready for review October 24, 2023 21:29
@svetlanabrennan svetlanabrennan requested a review from a team as a code owner October 24, 2023 21:29
@svetlanabrennan svetlanabrennan changed the title chore: Add k8s 1.28 support chore: Add k8s v1.28.0-rc.1 support Oct 24, 2023
juanjjaramillo
juanjjaramillo requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@juanjjaramillo juanjjaramillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall. My only comments are related to the exceptions files, and since I will locally run tests I will check if my comments make sense. For now, I am blocking the PR to buy me some time

.github/workflows/e2e.yaml Show resolved Hide resolved
e2e/1_28-exceptions.yml Show resolved Hide resolved
e2e/1_28-exceptions.yml Outdated Show resolved Hide resolved
juanjjaramillo
juanjjaramillo requested changes Oct 28, 2023
View reviewed changes
e2e/1_28-exceptions.yml Outdated Show resolved Hide resolved
juanjjaramillo
juanjjaramillo approved these changes Nov 1, 2023
View reviewed changes
e2e/1_27-exceptions.yml Outdated Show resolved Hide resolved
@svetlanabrennan svetlanabrennan merged commit 38fcec0 into main Nov 2, 2023
24 checks passed
@svetlanabrennan svetlanabrennan deleted the add-k8s-1.28-support branch November 2, 2023 22:10
csongnr pushed a commit that referenced this pull request Nov 9, 2023
@svetlanabrennan @juanjjaramillo @csongnr
chore: Add k8s v1.28.0-rc.1 support (#919)
26b26dc 
Co-authored-by: Juan Jose Jaramillo <juanjjaramillo@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanjjaramillo juanjjaramillo juanjjaramillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svetlanabrennan @juanjjaramillo