Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Updated go-mssqldb package to latest and removed verification of username presence on arguments.
Windows authentication currently fails. Providing just the domain user as username and no password as specified in the docs and code causes an error such as this:
Error creating connection to SQL Server: InitialBytes InitializeSecurityContext failed
Upgrading the go-mssqldb package to latest alone to support NTLMv2 does not appear to solve the issue entirely as there appear to be a bug with providing username. We found that providing neither username nor password allows windows authentication to work correctly using the host. Therefore the hard validation on username is removed to allow connections to be made without wither username or password.
Relevant dependency issues:
PR Review Checklist
Author
Reviewer