Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows authentication support #42

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Conversation

jsbnr
Copy link
Contributor

@jsbnr jsbnr commented Jul 22, 2020

Description of the changes

Updated go-mssqldb package to latest and removed verification of username presence on arguments.

Windows authentication currently fails. Providing just the domain user as username and no password as specified in the docs and code causes an error such as this:
Error creating connection to SQL Server: InitialBytes InitializeSecurityContext failed

Upgrading the go-mssqldb package to latest alone to support NTLMv2 does not appear to solve the issue entirely as there appear to be a bug with providing username. We found that providing neither username nor password allows windows authentication to work correctly using the host. Therefore the hard validation on username is removed to allow connections to be made without wither username or password.

Relevant dependency issues:

PR Review Checklist

Author

  • add a risk label after carefully considering the "blast radius" of your changes
  • describe the intent of your changes in the description. don't just rewrite your code in prose
  • assign at least one reviewer

Reviewer

  • review code for readability
  • verify that high risk behavior changes are well tested
  • check license for any new external dependency
  • ask questions about anything that isn't clear and obvious
  • approve the PR when you consider it's good to merge

@camdencheek camdencheek merged commit 57ac729 into newrelic:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants