Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysql log commit #97

Merged
merged 7 commits into from
Feb 14, 2022
Merged

Mysql log commit #97

merged 7 commits into from
Feb 14, 2022

Conversation

lchapman4
Copy link
Contributor

No description provided.

Updated the goreleaser file to include the new mysql-log.yml.sample file. This new .sample file will allow users to automatically send mysql logs to NR, properly formattted, just by renaming this file to .yml.
updated the destination for the new mysql-log.yml.sample file.
Updated the filename to be consistent with other .example logging files in the logging.d directory
- name: "mysqllog"
file: /var/log/mysql/error.log
attributes:
logtype: mysql-error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing trailing \n at the end of the file :)

@roobre
Copy link
Contributor

roobre commented Feb 11, 2022

Hey there @lchapman4,
PR looks all good to me! However github will not let me merge it if commits are not signed, as this is an NR security requirement. Do you think you can enable that? Github provides some guidance here.

lchapman4 and others added 3 commits February 11, 2022 14:55
Just updated the files with harmless comments to make sure the commits show as verified.
Trying to get my commits verified.
@roobre roobre merged commit 8f637d1 into newrelic:master Feb 14, 2022
@lchapman4 lchapman4 deleted the mysql-log-commit branch August 1, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants