Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: Dropped support for Node 14 #401

Merged
merged 2 commits into from
Jan 19, 2024
Merged

chore!: Dropped support for Node 14 #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33218a7
chore!: Dropped support for Node 14
mrickard Jan 18, 2024
5f8f4f9
chore: Delinted
mrickard Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,6 @@ custom:

This plugin currently supports the following AWS runtimes:

- nodejs14.x
- nodejs16.x
- nodejs18.x
- nodejs20.x
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "serverless-newrelic-lambda-layers",
"version": "4.3.0",
"version": "5.0.0",
"description": "Serverless plugin for NewRelic APM AWS Lambda layers.",
"main": "dist/index.js",
"files": [
Expand Down
7 changes: 1 addition & 6 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ const logShim = {
};

const wrappableRuntimeList = [
"nodejs14.x",
"nodejs16.x",
"nodejs18.x",
"nodejs20.x",
Expand Down Expand Up @@ -751,11 +750,7 @@ or make sure that you already have Serverless 3.x installed in your project.
}

private getHandlerWrapper(runtime: string, handler: string) {
if (
["nodejs14.x", "nodejs16.x", "nodejs18.x", "nodejs20.x"].indexOf(
runtime
) !== -1
) {
if (["nodejs16.x", "nodejs18.x", "nodejs20.x"].indexOf(runtime) !== -1) {
return "newrelic-lambda-wrapper.handler";
}

Expand Down
6 changes: 0 additions & 6 deletions tests/fixtures/debug.input.service.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,6 @@
},
"disabledDeprecations": [],
"functions": {
"layer-nodejs14x": {
"events": [{ "schedule": "rate(5 minutes)" }],
"handler": "handler.handler",
"package": { "exclude": ["./**"], "include": ["handler.js"] },
"runtime": "nodejs14.x"
},
"layer-nodejs16x": {
"events": [{ "schedule": "rate(5 minutes)" }],
"handler": "handler.handler",
Expand Down
22 changes: 0 additions & 22 deletions tests/fixtures/debug.output.service.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,28 +27,6 @@
},
"disabledDeprecations": [],
"functions": {
"layer-nodejs14x": {
"events": [{ "schedule": "rate(5 minutes)" }],
"handler": "newrelic-lambda-wrapper.handler",
"layers": [
"arn:aws:lambda:us-east-1:451483290750:layer:NewRelicNodeJS14X:118"
],
"package": {
"exclude": ["./**", "!newrelic-wrapper-helper.js"],
"include": ["handler.js"]
},
"runtime": "nodejs14.x",
"environment": {
"NEW_RELIC_ACCOUNT_ID": "${env:NEW_RELIC_ACCOUNT_ID}",
"NEW_RELIC_APP_NAME": "layer-nodejs14x",
"NEW_RELIC_LAMBDA_HANDLER": "handler.handler",
"NEW_RELIC_LOG": "stdout",
"NEW_RELIC_LOG_ENABLED": "true",
"NEW_RELIC_LOG_LEVEL": "debug",
"NEW_RELIC_NO_CONFIG_FILE": "true",
"NEW_RELIC_TRUSTED_ACCOUNT_KEY": "${env:NEW_RELIC_ACCOUNT_ID}"
}
},
"layer-nodejs16x": {
"events": [{ "schedule": "rate(5 minutes)" }],
"handler": "newrelic-lambda-wrapper.handler",
Expand Down
Loading