Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Automated release creation #421

Merged
merged 7 commits into from
Mar 22, 2024
Merged

Conversation

mrickard
Copy link
Member

Changed title of main workflow, to be standardized with other repos.
Added NEWS.md release history
Added release prep, creation, and pr validation workflows from aws-sdk repo

Closes #390
Closes NR-184573

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.14%. Comparing base (89d350a) to head (b3497ca).

❗ Current head b3497ca differs from pull request most recent head ba128e1. Consider uploading reports for the commit ba128e1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   35.14%   35.14%           
=======================================
  Files           4        4           
  Lines         552      552           
  Branches      149      149           
=======================================
  Hits          194      194           
  Misses        329      329           
  Partials       29       29           
Flag Coverage Δ
unit-tests 35.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
…validation

Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
@bizob2828 bizob2828 self-assigned this Mar 21, 2024
Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine and hard to test until we actually have to release. One comment on changelog but you'll need a few more things:

  • I would add a pull request template
  • add dependabot.yml to control conventional commits for its Prs

You can see examples here

Also you're going to want to update the pull request settings:

  • only squash merges and use pull request title
  • delete head branches
screenshot 2024-03-20 at 9 19 13 AM

.github/workflows/create-release.yml Outdated Show resolved Hide resolved
.github/workflows/prepare-release.yml Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
@mrickard mrickard requested a review from bizob2828 March 22, 2024 19:11
@mrickard
Copy link
Member Author

@bizob2828 I've updated the PR settings as well as adding templates.

@mrickard mrickard merged commit 9a05e0b into master Mar 22, 2024
10 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Mar 22, 2024
@mrickard mrickard deleted the NR-184573/automate-release branch March 22, 2024 20:34
@github-actions github-actions bot mentioned this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Automate regular chores (SLS plugin)
2 participants