Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws): update to aws example in cloud integrations #2380

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

pranav-new-relic
Copy link
Member

@pranav-new-relic pranav-new-relic commented May 26, 2023

This PR comprises changes made to the AWS integration example to adapt to the new AWS provider (5.0.0)
Two major changes -

  1. The block s3_configuration is now expected to be a nested block within the block http_endpoint_configuration, as per the updated documentation of the aws_kinesis_firehose_delivery_stream resource.
  2. The attributes buffer_size and buffer_interval have been renamed to buffering_size and buffering_interval.

@pranav-new-relic pranav-new-relic marked this pull request as ready for review May 26, 2023 07:54
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023

Codecov Report

Merging #2380 (b8dc1ac) into main (a1c810d) will not change coverage.
The diff coverage is n/a.

❗ Current head b8dc1ac differs from pull request most recent head 9089619. Consider uploading reports for the commit 9089619 to get more accurate results

@@           Coverage Diff           @@
##             main    #2380   +/-   ##
=======================================
  Coverage   33.97%   33.97%           
=======================================
  Files          91       91           
  Lines       24753    24753           
=======================================
  Hits         8409     8409           
  Misses      16192    16192           
  Partials      152      152           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pranav-new-relic
Copy link
Member Author

FYI: These changes have been validated; all specified resources are found to have been created successfully.

@pranav-new-relic pranav-new-relic merged commit ee6be1b into main Jun 5, 2023
5 of 6 checks passed
@pranav-new-relic pranav-new-relic deleted the chore/update-aws-example branch June 5, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants