Installation fixes (some may be Windows-specific, some not) #10
Conversation
git-filter-repo
Outdated
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env python3 | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
The commit message would need both an area prefix ("filter-repo: use python ...") and a Signed-off-by, but I can't take this change: see #4 (comment). We could add documentation that people need to change it, or even make it so if someone sets some variable then 'make install' will do the switch as part of the installation steps.
There was a problem hiding this comment.
Ugh, thanks for the link, finally an explanation! I looked all over the place trying to understand why a fresh python 3.8 install failed so miserably, but without luck... I guess "python vs python3 shebang on windows" aren't great Google keywords :)
|
Oh, also, as I've stated elsewhere about git.git contributions, "New contributors might be surprised by the rigor of the code review process, and might assume they just aren't good enough to contribute. It might be useful to countermand that subtle unspoken assumption by pointing out how much existing long-term contributors spend revising patches. Personally, despite doing my best to think of issues and make sure to send in really high quality patches, I still generally expect to spend at least as much time after submitting patches revising them as I did in coming up with them originally, and I'm not surprised if the time is doubled. And that's after contributing for years. I don't generally experience reviews anywhere near as thorough in other communities." If I still have to spend lots of time revising patches I submit to git, you shouldn't feel bad when I come up with a list of improvements for your patches. If you'd like to update the first two as I suggested, I'd be happy to merge them. |
|
Comments addressed (commit message, signed-off by, using "origin/docs") |
As I said I don't have much experience contributing so I don't really have a frame of reference. Don't worry you didn't make me feel bad, I was indeed a little surprised 😄 but more like a stranger in a strange land ("oh that's how they roll over here? uh!"), I take it all in and learn. |
- correct paths to including missing "Documentation/" prefix - use fully specified "origin/docs" branch in case the "docs" branch is not checked out locally Signed-off-by: Benoit Fouletier <bennews@free.fr>
- quote paths that may have spaces - force ln in case the file already exists Signed-off-by: Benoit Fouletier <bennews@free.fr>
Done! |
|
Thanks! |
Side-note:
here's what ended up working for me to install on Windows:
git clone -c core.symlinks=true https://github.com/newren/git-filter-repo.git
make prefix="C:\Program Files\Git\mingw64" pythondir="C:\Python38\Lib\site-packages" mandir="C:\gnuwin32\share\man" install