Optimizing stinging URL, by doing it in parallel. #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about adding this as a command line flag to hit urls in parallel vs sequentially? Not sure that defaulting to parallel is always the right approach. |
|
Cool...I'll give it a shot. |
added 2 commits
July 5, 2016 18:29
|
@cosmin May you please take another look 👀 ? |
richardtylee
changed the title
|
Thanks @astierler . My apologies. New PR: #153 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we sting URLs, we are stinging them serially. When there are many URLs, an attack will take a long time to complete. Let's sting in parallel.