Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ConfigPaths and CliArgParser FFI use Vec<u8>/&[u8] for filepaths #2644

Closed
Minoru opened this issue Dec 29, 2023 · 4 comments · Fixed by #2653
Closed

Ensure ConfigPaths and CliArgParser FFI use Vec<u8>/&[u8] for filepaths #2644

Minoru opened this issue Dec 29, 2023 · 4 comments · Fixed by #2653
Labels
bug This issue reports a problem that ought to be fixed rust-port

Comments

@Minoru
Copy link
Member

Minoru commented Dec 29, 2023

This is split from #2561 (review). On the feature/2326-filepath branch, we should look through rust/libnewsboat-ffi/ and fix all places where paths are passed as Strings.

This is part of #2326.

@Minoru Minoru added bug This issue reports a problem that ought to be fixed rust-port labels Dec 29, 2023
@dennisschagt
Copy link
Member

I'm planning to implement this using the filepath::PathBuf, similar to the changes in #2652

@Minoru
Copy link
Member Author

Minoru commented Jan 23, 2024

Somehow this wasn't auto-closed by #2653 which resolves this issue.

@Minoru Minoru closed this as completed Jan 23, 2024
@dennisschagt
Copy link
Member

The "magic" resolves ... text didn't work either so I added the link manually after opening the PR.
I guess that's just a Github behavior for PR's which don't go into the default (master) branch.

@Minoru
Copy link
Member Author

Minoru commented Jan 23, 2024

Oh, you're totally right: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword#linking-a-pull-request-to-an-issue-using-a-keyword

Note: The special keywords in a pull request description are interpreted when the pull request targets the repository's default branch. However, if the PR's base is any other branch, then these keywords are ignored, no links are created and merging the PR has no effect on the issues. If you want to link a pull request to an issue using a keyword, the PR must be on the default branch.

Live and learn :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue reports a problem that ought to be fixed rust-port
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants