Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation warning #3

Closed
Minoru opened this issue Nov 27, 2021 · 2 comments · Fixed by #4
Closed

Fix indentation warning #3

Minoru opened this issue Nov 27, 2021 · 2 comments · Fixed by #4

Comments

@Minoru
Copy link
Member

Minoru commented Nov 27, 2021

On 127c0b2, with GCC 10.2.1 when running make:

widgets/wt_list.c: In function ‘fix_offset_pos’:
widgets/wt_list.c:76:3: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
   76 |   if (stfl_widget_getkv_int(c, L"can_focus", 1) &&
      |   ^~
widgets/wt_list.c:79:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
   79 |    latest_widget = c;
      |    ^~~~~~~~~~~~~

Looks like a mistake in 0cc16e7?

cc @dennisschagt

@Minoru Minoru mentioned this issue Nov 27, 2021
@dennisschagt
Copy link
Member

Looks like a mistake in 0cc16e7?

Jup, looks like a mistake.

I don't think it has any effect on Newsboat because we don't use any hidden or non-focusable lines in the listviews.
However, I will create a PR to fix this.

@Minoru
Copy link
Member Author

Minoru commented Nov 29, 2021

Ah, cool. Thank you!

@Minoru Minoru closed this as completed in #4 Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants