This repository has been archived by the owner on Sep 3, 2019. It is now read-only.
WIP: AENV-224: save button and toolbar icons are being disabled in ff 30.0 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls check travis logs, IE 11.0.0 (Windows 8.1 0.0.0) Directive: sfAlohaFormatGeneric called the correct Aloha.execCommand FAILED |
|
is it possible to turn off automated testing for IE? There will probably be a lot of test that fail there, and I don't think we are really officially supporting it. |
|
yes, it's possible in karma.js file. Scoopwriter supports IE10+ (https://github.com/newscoop/JS-Scoopwriter#browser-compatibility), according to tests. All tests were passing on IE 10+ so far, so I don't think it's a good idea to disable it at all |
thnkloud9
changed the title
|
Leaving this change out for now until the IE issues can be sorted. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed by manually setting alohaEditable based on range selection, and triggering "aloha-smart-content-changed" event manually. Still not sure why these are not handled by Aloha internally for FF though.