chore(PPDSC-2625): remove optional keys

newscorp-ghfb · Jan 19, 2023 · cfb6819 · cfb6819
1 parent 91d56db
commit cfb6819
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 14 deletions.
diff --git a/site/utils/google-sheet/__tests__/utils.test.ts b/site/utils/google-sheet/__tests__/utils.test.ts
@@ -88,24 +88,19 @@ describe('parseCMSResponse', () => {
   it('should return the parsed content if all keys are valid', () => {
     const response = [
       ['required_key', 'required_value'],
-      ['optional_key', 'optional_value'],
       ['dynamic_key_0', 'dynamic_value_0'],
       ['dynamic_key_1', 'dynamic_value_1'],
     ];
     const parsed = parseCMSResponse(response, {
       required: {
         required_key: 'required_key',
       },
-      optional: {
-        optional_key: 'optional_key',
-      },
       dynamic: {
         dynamic_key_: 'dynamic_key_',
       },
     });
     expect(parsed).toEqual({
       required_key: 'required_value',
-      optional_key: 'optional_value',
       dynamic_key_0: 'dynamic_value_0',
       dynamic_key_1: 'dynamic_value_1',
     });

diff --git a/site/utils/google-sheet/types.ts b/site/utils/google-sheet/types.ts
@@ -2,12 +2,6 @@ export type PageCMSRequiredProps<T extends string> = {
   [key in T]: string;
 };
 
-export type PageCMSOptionalProps<T extends string> = Partial<
-  {
-    [key in T]: string;
-  }
->;
-
 export type PageCMSPrefixedProps<T extends string> = {
   [key in `${T}${number}`]: string;
 };

diff --git a/site/utils/google-sheet/utils.ts b/site/utils/google-sheet/utils.ts
@@ -21,11 +21,9 @@ export const parseCMSResponse = <T extends CMSProps>(
   cmsResponse: CMSResponse,
   {
     required,
-    optional = {},
     dynamic = {},
   }: {
     required: Record<string, string>;
-    optional?: Record<string, string>;
     dynamic?: Record<string, string>;
   },
 ): T => {
@@ -36,7 +34,7 @@ export const parseCMSResponse = <T extends CMSProps>(
 
   const missingKeys = Object.keys(required).filter(key => !content[key]);
   const invalidKeys = Object.keys(content).filter(key => {
-    if (required[key] || optional[key]) {
+    if (required[key]) {
       return false;
     }
     const prefixMatch = Object.keys(dynamic).find(k =>