Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2477): remove sourcepoint component #461

Merged
merged 15 commits into from
Mar 27, 2023

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Nov 7, 2022

PPDSC-2477

What

What did you do - removed the Consent component, the consent code will be loaded directly from tealium

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the docs Improvements or additions to documentation label Nov 7, 2022
@mutebg mutebg marked this pull request as ready for review November 7, 2022 08:37
@mutebg mutebg added ready for review Please assist in getting this reviewed DO NOT MERGE Do not merge this PR labels Nov 7, 2022
@@ -246,14 +236,14 @@ export default class MyDocument extends Document {
}
`}
/>
{isSiteEnvProduction && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this condition there originally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vanals I see this has been added to remove it for SVG Previewer, do we still need that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rings a bell. I think it breaks a figma plugin or something?

Copy link
Contributor

@Vanals Vanals Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey! sorry saw this randomly now.
I think the reason was that tealium did break our website from being rendered in a Iframe. This stopped designers from being able to use the previewer. Removing it from dev allows designers to use the Previewers with no issue, so yeah this should stay I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we move that to _app.tsx and from there we can have access to url "path" and disable it only for preview URL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the code

JohnTParsons
JohnTParsons previously approved these changes Dec 19, 2022
@mutebg mutebg requested a review from a team as a code owner January 16, 2023 04:49
@mutebg mutebg removed the ready for review Please assist in getting this reviewed label Mar 23, 2023
@mutebg mutebg added ready for review Please assist in getting this reviewed and removed DO NOT MERGE Do not merge this PR labels Mar 23, 2023
@mutebg mutebg merged commit 2950541 into main Mar 27, 2023
@mutebg mutebg deleted the docs/PPDSC-2477-consolidate-sourcepoint branch March 27, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants