Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2657): make sidebar drawer dismissed when click on the menuItem #550

Merged
merged 2 commits into from Jan 6, 2023

Conversation

Xin00163
Copy link
Contributor

@Xin00163 Xin00163 commented Jan 6, 2023

PPDSC-2657

Burger menu should close when current page reselected (by clicking on the item for the current page on the burger menu).
Instead, it sends events and the menu stays open.

This fix is to update the state when a menuItem is clicked.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@Xin00163 Xin00163 requested a review from a team as a code owner January 6, 2023 12:02
@github-actions github-actions bot added the docs Improvements or additions to documentation label Jan 6, 2023
@Xin00163 Xin00163 added the ready for review Please assist in getting this reviewed label Jan 6, 2023
Copy link
Contributor

@baburay23 baburay23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Xin00163 Xin00163 merged commit 13f19e6 into main Jan 6, 2023
@Xin00163 Xin00163 deleted the docs/PPDSC-2657-burger-menu-drawer-dismiss branch January 6, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants