Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2693): add stylePreset to TextBlock #566

Merged
merged 1 commit into from Jan 18, 2023

Conversation

Xin00163
Copy link
Contributor

PPDSC-2693

On the NewsKit.co.uk roadmap page this text: “The roadmap is a living document, and it is likely that priorities will change” is black instead of white when the page is viewed in dark mode

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@Xin00163 Xin00163 requested a review from a team as a code owner January 17, 2023 14:51
@Xin00163 Xin00163 added the ready for review Please assist in getting this reviewed label Jan 17, 2023
@github-actions github-actions bot added the docs Improvements or additions to documentation label Jan 17, 2023
@Xin00163 Xin00163 merged commit 9bf2a2f into main Jan 18, 2023
@Xin00163 Xin00163 deleted the docs/PPDSC-2693-roadmap-incorrect-text-color branch January 18, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants