Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/ppdsc 2616 onboarding new pages #573

Merged
merged 22 commits into from Jan 25, 2023

Conversation

baburay23
Copy link
Contributor

@baburay23 baburay23 commented Jan 19, 2023

PPDSC-2616

What

  1. Background - why this is needed
  2. What did you do-added onboarding pages (3 of them) under patterns
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@baburay23 baburay23 requested a review from a team as a code owner January 19, 2023 14:00
@github-actions github-actions bot added the docs Improvements or additions to documentation label Jan 19, 2023
@baburay23 baburay23 added the WIP Work in progress label Jan 19, 2023
@pp-serviceaccount
Copy link
Collaborator

@baburay23 baburay23 removed the WIP Work in progress label Jan 24, 2023
@baburay23 baburay23 added ready for review Please assist in getting this reviewed and removed Requires design review labels Jan 25, 2023
@baburay23 baburay23 changed the title Docs/ppdsc 2616 onboarding new pages docs/ppdsc 2616 onboarding new pages Jan 25, 2023
@baburay23 baburay23 merged commit 9845a9e into main Jan 25, 2023
@baburay23 baburay23 deleted the docs/PPDSC-2616-onboarding-new-pages branch January 25, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants