Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(PPDSC-2497): layer & layerOrganizer docs #574

Merged
merged 6 commits into from Jan 24, 2023
Merged

docs(PPDSC-2497): layer & layerOrganizer docs #574

merged 6 commits into from Jan 24, 2023

Conversation

Xin00163
Copy link
Contributor

@Xin00163 Xin00163 commented Jan 19, 2023 •
edited

PPDSC-2497
Designs: https://www.figma.com/file/TiFj23lTJJwug5ADTx2Szu/02---NK-Web---Components---Layer?node-id=1%3A6 - Connect your Figma account

Illustrations: Layer

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@Xin00163 Xin00163 requested a review from a team as a code owner January 19, 2023 17:48
@github-actions github-actions bot added the docs Improvements or additions to documentation label Jan 19, 2023
@pp-serviceaccount
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2497-layer-component
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2497-layer-component/storybook

@Xin00163 Xin00163 added the ready for review Please assist in getting this reviewed label Jan 23, 2023
@baburay23 baburay23 self-requested a review January 24, 2023 11:08
@Xin00163 Xin00163 merged commit 7778abe into main Jan 24, 2023
@Xin00163 Xin00163 deleted the docs/PPDSC-2497-layer-component branch January 24, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutebg mutebg mutebg approved these changes

@baburay23 baburay23 baburay23 approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Xin00163 @pp-serviceaccount @mutebg @baburay23