Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2710): update image component storybook scenarios #595

Merged

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2710

What

Updated Image storybook scenarios

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:
image

After:
image

Who should review this PR:

How to test:

@evgenitsn evgenitsn added docs Improvements or additions to documentation Requires design review labels Jan 31, 2023
@evgenitsn evgenitsn requested a review from a team as a code owner January 31, 2023 11:16
@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed and removed Requires design review labels Jan 31, 2023
Vanals
Vanals previously approved these changes Feb 2, 2023
Xin00163
Xin00163 previously approved these changes Feb 3, 2023
@evgenitsn evgenitsn dismissed stale reviews from Xin00163 and Vanals via 218c660 February 6, 2023 09:21
@evgenitsn
Copy link
Contributor Author

@Vanals @Xin00163 thanks for reviews, I had to update the scenario parameters for some of the stories. Can I get reviews again. 🙏

@evgenitsn evgenitsn merged commit 4967e70 into main Feb 10, 2023
@evgenitsn evgenitsn deleted the docs/PPDSC-2710-update-image-component-storybook-scenarios branch February 10, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants