Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PPDSC-2797): remove headless browsers #609

Merged
merged 5 commits into from Feb 7, 2023

Conversation

LukeFinch
Copy link
Contributor

@LukeFinch LukeFinch commented Feb 7, 2023

PPDSC-2797

What

  1. Background - We're getting pipeline failures waiting to install browsers from the ubuntu servers
  2. What did you do - change the docker image to come pre-shipped with browsers
  3. What does the reviewers should expect - pipeline should build as expected, with no calls to download headless browsers

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@LukeFinch LukeFinch requested a review from a team as a code owner February 7, 2023 09:17
@baburay23 baburay23 self-requested a review February 7, 2023 10:54
@LukeFinch LukeFinch merged commit 81076da into main Feb 7, 2023
@LukeFinch LukeFinch deleted the fix/PPDSC-2797-remove-headless-chrome-installs branch February 7, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants