Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PPDSC-1866): handle string line height #643

Merged
merged 3 commits into from Feb 17, 2023
Merged

Conversation

mstuartf
Copy link
Contributor

@mstuartf mstuartf commented Feb 16, 2023

PPDSC-1866

What

  1. Background - why this is needed
  • Time and Marketwatch use string lineHeight
  1. What did you do
  • Parse string line heights
  1. What does the reviewers should expect
  • Storybook works for Times and Marketwatch themes

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mstuartf mstuartf added fix This change fixes a bug ready for review Please assist in getting this reviewed labels Feb 16, 2023
@mstuartf mstuartf requested a review from a team as a code owner February 16, 2023 15:12
evgenitsn
evgenitsn previously approved these changes Feb 16, 2023
@pp-serviceaccount
Copy link
Collaborator

@mstuartf mstuartf merged commit 91021ec into main Feb 17, 2023
@mstuartf mstuartf deleted the fix/PPDSC-1866-line-height branch February 17, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants