Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PPDSC-2837): update TNL font #649

Merged
merged 3 commits into from Feb 22, 2023
Merged

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2837

What

Updated TNL font from GillSansMTStd to Roboto
Removed all GillSansMTStd references
Added Roboto-Medium files locally

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed feature This change contains a new feature labels Feb 17, 2023
@evgenitsn evgenitsn requested a review from a team as a code owner February 17, 2023 11:58
@pp-serviceaccount
Copy link
Collaborator

@evgenitsn evgenitsn added ready for design review Please assist in getting this reviewed ready for review Please assist in getting this reviewed and removed ready for review Please assist in getting this reviewed ready for design review Please assist in getting this reviewed labels Feb 20, 2023
@evgenitsn evgenitsn merged commit eff6c2a into main Feb 22, 2023
@evgenitsn evgenitsn deleted the chore/PPDSC-2837-update-TNL-font branch February 22, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants