Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(PPDSC-2811): update screen-reader-only scenarios #662

Merged
merged 6 commits into from Mar 1, 2023
Merged

docs(PPDSC-2811): update screen-reader-only scenarios #662

merged 6 commits into from Mar 1, 2023

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Feb 23, 2023

PPDSC-2811

What

Update storybook scenarios for ScreenReaderOnly

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the docs Improvements or additions to documentation label Feb 23, 2023
@pp-serviceaccount
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2811-screen-reader-only-scenarios
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2811-screen-reader-only-scenarios/storybook

@mutebg mutebg added the ready for design review Please assist in getting this reviewed label Feb 23, 2023
@mutebg mutebg added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Feb 24, 2023
@JohnTParsons JohnTParsons changed the title docs(PPDSC-2811): update screen-reader-only scenarious docs(PPDSC-2811): update screen-reader-only scenarios Feb 28, 2023
@mutebg mutebg marked this pull request as ready for review February 28, 2023 10:43
@mutebg mutebg requested a review from a team as a code owner February 28, 2023 10:43
@mutebg mutebg merged commit bdeaf1c into main Mar 1, 2023
@mutebg mutebg deleted the docs/PPDSC-2811-screen-reader-only-scenarios branch March 1, 2023 07:45
JohnTParsons pushed a commit that referenced this pull request Mar 7, 2023
@mutebg
docs(PPDSC-2811): update screen-reader-only scenarios (#662)
c1b7a63 
* docs(PPDSC-2811): update screen-reader-only scenarious

* docs(PPDSC-2811): update text in sr

* docs(PPDSC-2811): change link url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTParsons JohnTParsons JohnTParsons approved these changes

@mstuartf mstuartf mstuartf approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mutebg @pp-serviceaccount @JohnTParsons @mstuartf