Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(PPDSC-0000): updating channel for ci notifycations #685

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

Vanals
Copy link
Contributor

@Vanals Vanals commented Mar 3, 2023

PPDSC-XXXX

What
Updated channel for Ci notifications

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@Vanals Vanals requested a review from a team as a code owner March 3, 2023 15:04
@Vanals Vanals merged commit 57bc315 into main Mar 6, 2023
@Vanals Vanals deleted the ci/PPDSC-0000-update-circle-ci-notify-channel branch March 6, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants