Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ISSUE-4): add fullWidthSingleCell prop to structuredListCell #693

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

Xin00163
Copy link
Contributor

@Xin00163 Xin00163 commented Mar 8, 2023

#690

What

  1. Background - As a user, I would like to align the divider and content when there is only one cell in StructuredList so there is no extra padding/margin
  2. What did you do - to avoid making a breaking change, I've added a prop to allow this to happen
  3. What does the reviewers should expect - The rest of the scenarios should still work as expected. There is one extra scenario added to one cell.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@Xin00163 Xin00163 requested a review from a team as a code owner March 8, 2023 12:24
@github-actions github-actions bot added the fix This change fixes a bug label Mar 8, 2023
@Xin00163 Xin00163 added the ready for review Please assist in getting this reviewed label Mar 8, 2023
@@ -44,4 +44,5 @@ export interface StructuredListCellProps extends CellProps {
children: React.ReactNode;
pullRight?: boolean;
align?: StructuredListCellAlign;
fullWidthSingleCell?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Xin00163 Xin00163 merged commit dd78357 into main Mar 9, 2023
@Xin00163 Xin00163 deleted the fix/Issue-4-add-full-width-to-list-cell branch March 9, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants