Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(PPDSC-0000): storybook & docs updates #698

Merged
merged 12 commits into from
Mar 10, 2023
Merged

docs(PPDSC-0000): storybook & docs updates #698

merged 12 commits into from
Mar 10, 2023

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Mar 10, 2023

PPDSC-0000

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

mutebg and others added 11 commits March 2, 2023 09:11
@mutebg
docs(PPDSC-2705): update grid storybook scenarios (#664)
a6001bd 
* docs(PPDSC-2705): update grid storybook scenarious

* docs(PPDSC-2705): design review

* docs(PPDSC-2705): update bg
@evgenitsn
docs(PPDSC-2825): update UnorderedList component storybook scenarios (#…
0f0d956 
…674)

* docs(PPDSC-2825): update UnorderedList component storybook scenarios

* docs(PPDSC-2825): address design comments
@baburay23
docs(PPDSC-2816)update-stack-child-component-storybook-scenarios (#666)
1c2d26e 
* docs(PPDSC-2816): chore/ppdse-2816-added new stack c scenes

* docs(PPDSC-2816): chore/ppdse-2816-tidy up

* docs(PPDSC-2816): chore/ppdse-2816-addressed comments

* docs(PPDSC-2816): chore/ppdse-2816-test

* docs(PPDSC-2816): chore/ppdse-2816-removed space
@mstuartf @jannuk59
docs(PPDSC-2827): update scenarios (#668)
e381afa 
* docs(PPDSC-2827): update scenarios

* Docs/ppdsc 2562 content updates miscellaneous (#633)

* docs(PPDSC-2562): colours content updates

* docs(PPDSC-2562): miscellaneous - website content updates

* docs(PPDSC-2562): mobile device fonts fix

* docs(PPDSC-2562): components overview structure change

* docs(PPDSC-2562): utilties session subNav fix

* docs(PPDSC-2562): update theme/overview page

* docs(PPDSC-2562): components overview page

* docs(PPDSC-2562): utilites session implementation

* docs(PPDSC-2562): components overview page

* docs(PPDSC-2562): arialabelby fix

---------

Co-authored-by: Ravindren <jravindren@NTS251819MC.local>
Co-authored-by: Stoyan Delev <stoyan.delev@news.co.uk>

* Fix/ppdsc 2854 flaky tests (#680)

* fix(PPDSC-2854): don't set initial time until duration is set

* fix(PPDSC-2854): update baseline warning

* fix(PPDSC-2854): revert yarn lock changes

* Bumping to version v7.0.0 - [skip ci]

---------

Co-authored-by: jannuk59 <janani.ravindren@news.co.uk>
Co-authored-by: Ravindren <jravindren@NTS251819MC.local>
Co-authored-by: Stoyan Delev <stoyan.delev@news.co.uk>
Co-authored-by: Product Platforms Service <ncu-product-platforms@news.co.uk>
@mstuartf
docs(PPDSC-2815): update stack scenarios (#665)
0f7fddd 
* docs(PPDSC-2815): update stack scenarios

* docs(PPDSC-2815): remove variations

* docs(PPDSC-2815): correct story url

* docs(PPDSC-2815): update colours

* docs(PPDSC-2815): fix
@mutebg
docs(PPDSC-2845): update image playground (#681)
c0e3c93
docs(PPDSC-2851): update snaps
3407433
@RashikaNewsUK
docs(PPDSC-2800) inline-message-comp-update (#684)
639c614 
* docs(PPDSC-2800): docs(PPDSC-2800) inline-message-comp-updatees
@evgenitsn
docs(PPDSC-2708): update IconButton component storybook scenarios (#682)
1a4d407 
* docs(PPDSC-2708): update IconButton component storybook scenarios

* docs(PPDSC-2708): fix e2e

* docs(PPDSC-2708): add icon size overrides example

* docs(PPDSC-2708): extracting appearances as const
@mutebg
Docs/ppdsc 2851 media query hooks message (#689)
22086a5 
* docs(PPDSC-2851): add inline-message to hooks page

* docs(PPDSC-2851): update texts

* docs(PPDSC-2851): update comment color in code-examples

* docs(PPDSC-2851): update snaps
@Xin00163
docs/PPDSC-2802: layer scenarios (#687)
a1a3e39 
* fix(PPDSC-2802): update layer scenarios

* fix(PPDSC-2802): update storybook link

* fix(PPDSC-2802): update story names

* fix(PPDSC-2802): address design comments
@github-actions github-actions bot added the docs Improvements or additions to documentation label Mar 10, 2023
@mutebg mutebg changed the title Docs/ppdsc 0000 storybook updates docs(PPDSC-0000): storybook updates Mar 10, 2023
@mutebg mutebg changed the title docs(PPDSC-0000): storybook updates docs(PPDSC-0000): storybook & docs updates Mar 10, 2023
@mutebg mutebg marked this pull request as ready for review March 10, 2023 05:53
@mutebg mutebg requested a review from a team as a code owner March 10, 2023 05:53
@pp-serviceaccount
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/ppdsc-0000-storybook-updates
Storybook: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/ppdsc-0000-storybook-updates/storybook

@mutebg mutebg added the ready for review Please assist in getting this reviewed label Mar 10, 2023
@mutebg mutebg merged commit 54c7172 into main Mar 10, 2023
@mutebg mutebg deleted the docs/PPDSC-0000-storybook-updates branch March 10, 2023 08:05
JohnTParsons
JohnTParsons reviewed Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@JohnTParsons JohnTParsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTParsons JohnTParsons JohnTParsons left review comments

@evgenitsn evgenitsn evgenitsn approved these changes

@RashikaNewsUK RashikaNewsUK RashikaNewsUK approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mutebg @pp-serviceaccount @evgenitsn @JohnTParsons @RashikaNewsUK @baburay23 @mstuartf @Xin00163