Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2704): update stories #714

Merged
merged 6 commits into from
Mar 24, 2023
Merged

Conversation

mstuartf
Copy link
Contributor

@mstuartf mstuartf commented Mar 20, 2023

PPDSC-2704

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mstuartf mstuartf added the ready for design review Please assist in getting this reviewed label Mar 20, 2023
@mstuartf mstuartf requested a review from a team as a code owner March 20, 2023 16:32
@github-actions github-actions bot added the docs Improvements or additions to documentation label Mar 20, 2023
@mstuartf mstuartf added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Mar 21, 2023
<FormInputCheckbox
label="I want to hear about more offers"
value="tc"
id="interests-Science"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to pass the ID everywhere, or we have a bug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was getting a11y errors without. I think the issue was the ids for the two sets of radios / checkboxes were the same unless I set them manually.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I know why is happening, might create a ticket for that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDs should be lower-case I think, eg id="interests-science"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

mutebg
mutebg previously approved these changes Mar 22, 2023
mutebg
mutebg previously approved these changes Mar 23, 2023
@mstuartf mstuartf merged commit c7c0943 into main Mar 24, 2023
@mstuartf mstuartf deleted the docs/PPDSC-2704-form-input-stories branch March 24, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants